Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance coffee_httpd Test Structure and Remove Redundant Type Definitions #206

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Enhance coffee_httpd Test Structure and Remove Redundant Type Definitions #206

merged 1 commit into from
Oct 7, 2023

Conversation

tareknaser
Copy link
Collaborator

@tareknaser tareknaser commented Oct 7, 2023 •
edited by vincenzopalazzo
Loading

Description

  • This PR enhances the testing structure in coffee_httpd by breaking down the test into two.
    • All http endpoints are tested
      • In the httpd_add_remove_plugins test, we test endpoints like /remote/add, /install, /remote/list, /list, /remove, and /remote/rm
      • In httpd_search_list_plugins, we test (/remote/list_plugins, /show, /search)
  • Additionally, this PR eliminates redundant request type definitions found in coffee_lib/src/types/mod.rs

Related issue: #202

Fixes #202

@netlify
Copy link

netlify bot commented Oct 7, 2023 •
edited
Loading

✅ Deploy Preview for coffee-docs canceled.

Name Link
🔨 Latest commit 0bb5a04
🔍 Latest deploy log https://app.netlify.com/sites/coffee-docs/deploys/65215ab2a5617300073d2714

vincenzopalazzo
vincenzopalazzo reviewed Oct 7, 2023
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please remember to put the content inside your commit body other than the PR description.

If we change git host somedays we need to keep these informations

@vincenzopalazzo
Copy link
Contributor

Added the Fixes #202

to close the related issue when this is merged

@vincenzopalazzo vincenzopalazzo merged commit 2711bd6 into coffee-tools:master Oct 7, 2023
9 checks passed
@tareknaser tareknaser deleted the httpd_test branch October 8, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Integration Tests for coffee_httpd Crate
2 participants
@tareknaser @vincenzopalazzo